umputun / revdiff / 29967239830

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix(themes): resolve --theme auto from tmux client list instead of current client (#286)

* fix(themes): resolve --theme auto from tmux client list instead of current client

The plugin launcher's tmux backend runs revdiff in a detached session behind a display-popup attach. Once the popup client attaches, tmux resolves it as the current client for display-message, and a nested tmux client never learns a theme from the outer tmux — #{client_theme} expands empty, the masked OSC 11 fallback goes unanswered in that topology, and --theme auto lands on the dark default. Whether detection ran before or after the popup attach was a millisecond race, so auto themes flipped between correct and dark at random (and a lost race also stalled startup on termenv's 5s OSC timeout when stdout was a tty).

Detection now asks tmux for every server client's theme via list-clients and picks the most recently active client that reports one, so the outer terminal's client wins regardless of which client tmux considers current. Old tmux (< 3.5) and themeless terminals still fall through to the OSC 11 and COLORFGBG paths unchanged.

* fix(themes): prefer the current tmux client's theme over the server-wide pick

With several terminals attached to one tmux server, the server-wide recency pick can resolve a client attached to a different session than the one revdiff was launched from. Asking display-message for the current client's theme first scopes normal-pane launches to the launching session's client; the server-wide list-clients scan still rescues the detached-session popup topology, where the current client is a nested tmux client that never reports a theme.

Coverage Stats

13 of 24 new or added lines in 1 file covered. (54.17%)

1 existing line in 1 file now uncovered.

11013 of 12249 relevant lines covered (89.91%)

2927.93 hits per line