dangernoodle-io / breadboard / 29964909098

96%

push

github

refactor: create bb_diag_http and extract bb_diag's HTTP surface (B1-1153) (#1006)

- move platform/espidf/bb_diag/bb_diag_routes.c to bb_diag_http as
  bb_diag_http_routes.c: legacy exact routes (GET/DELETE /api/diag/boot,
  /panic, /coredump, /heap, /tasks, /sockets), gated CONFIG_BB_DIAG_ROUTES
- move platform/espidf/bb_diag/bb_diag_section_dispatch.c to bb_diag_http
  as bb_diag_http_section_dispatch.c: the /api/diag/* wildcard dispatcher,
  gated CONFIG_BB_DIAG_SECTIONS (an independent Kconfig from the routes above)
- split bb_diag_boot_wire.c: bb_diag_boot_render_envelope() (the sole
  reason that file included bb_http_server.h) moves to bb_diag_http as
  bb_diag_http_boot_wire.c; gather/bind logic stays in bb_diag, now
  bb_http_server-free
- relocate the Kconfig-gated public prototypes (bb_diag_routes_init,
  bb_diag_sections_init, bb_diag_boot_render_envelope) into a new public
  bb_diag_http.h; move BB_DIAG_ROUTES, BB_DIAG_PANIC_TRIGGER, and
  BB_DIAG_SECTIONS to bb_diag_http's own Kconfig (same symbol names, no
  sdkconfig changes needed)
- bb_diag_http follows bb_wifi_http's REQUIRES direction (REQUIRES bb_diag,
  never the reverse) but, unlike bb_wifi_http (which owns its own private
  headers), currently reaches bb_diag's shared internal headers via
  bb_diag's pre-existing public-root include dir -- a looseness that
  predates this PR, tracked separately rather than fixed here
- drop from bb_diag's CMakeLists.txt: bb_http_server (public REQUIRES);
  bb_http, bb_ntp, bb_ota_validator, bb_system, bb_task_registry, bb_task,
  bb_openapi, lwip (PRIV_REQUIRES) -- every remaining call site moved with
  the files that used them
- wire bb_diag_http into bbtool.toml's core (host tests) and floor
  (handwire HW-validation) capability manifests; update floor_app.c's
  include for the relocated bb_diag_sections_init() prototype
- deliberately edit the sat_sub fence baseline (component rename changes
  that marker's identity, not just its path) and ... (continued)

7386 of 7976 branches covered (92.6%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

12530 of 12692 relevant lines covered (98.72%)

2484.3 hits per line