umputun / revdiff / 29961688729

90%

master: 90%

Build Type

Pull #286

github

Committed by kylesnowschwartz

Commit Message

fix(themes): resolve --theme auto from tmux client list instead of current client

The plugin launcher's tmux backend runs revdiff in a detached session behind a display-popup attach. Once the popup client attaches, tmux resolves it as the current client for display-message, and a nested tmux client never learns a theme from the outer tmux — #{client_theme} expands empty, the masked OSC 11 fallback goes unanswered in that topology, and --theme auto lands on the dark default. Whether detection ran before or after the popup attach was a millisecond race, so auto themes flipped between correct and dark at random (and a lost race also stalled startup on termenv's 5s OSC timeout when stdout was a tty).

Detection now asks tmux for every server client's theme via list-clients and picks the most recently active client that reports one, so the outer terminal's client wins regardless of which client tmux considers current. Old tmux (< 3.5) and themeless terminals still fall through to the OSC 11 and COLORFGBG paths unchanged.

Pull Request Pull Request #286: fix(themes): resolve --theme auto from tmux client list instead of current client

Coverage Stats

13 of 16 new or added lines in 1 file covered. (81.25%)

1 existing line in 1 file now uncovered.

11013 of 12238 relevant lines covered (89.99%)

2930.56 hits per line