stacklok / toolhive / 29961439084
69%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 814
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.039% (+0.006%) from 69.033%
29961439084

push

github

web-flow 
Default storage version migrator to enabled in operator chart (#5603)

* Default storage version migrator to enabled

The StorageVersionMigrator controller shipped opt-in (chart default
false) so it could land without functional impact. It has soaked through
a release, so make the operator helm chart enable it by default: clusters
get their CRD status.storedVersions kept clean automatically, which is the
precondition for a future release to drop deprecated API versions without
orphaning etcd objects.

- Flip operator.features.storageVersionMigrator to true in values.yaml
- Update the default-install test to assert the env var renders "true"
- Add explicit opt-out (false) coverage to the feature-flags suite
- Refresh the chart README, reference docs, and upgrade-guide notes
- Sync the now-stale opt-in comments in the operator's env-var gate
  (the binary still defaults off when the var is unset; the chart sets it)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Reject storage version migrator in namespace scope

The StorageVersionMigrator watches cluster-scoped CustomResourceDefinitions
and re-stores custom resources across all namespaces, so it requires
cluster-scoped RBAC and a cluster-scoped manager cache. A namespace-scoped
operator gets only per-namespace RoleBindings and a namespace-restricted
cache, so the controller cannot sync its CRD informer and wedges the
manager — which is what broke the multi-tenancy chainsaw E2E once the
feature was defaulted on.

Add a Helm validation that fails the render when storageVersionMigrator is
true under operator.rbac.scope=namespace, with an actionable message. Fail
loudly rather than silently dropping the feature: a silent drop would let a
namespace-scoped admin believe storedVersions are being kept clean when they
are not, leading to the skip-a-version upgrade trap later.

- Add validateStorageVersionMigrator helper; invoke it from deployment.yaml
- Opt the namespace-scoped multi-te... (continued)

76790 of 111227 relevant lines covered (69.04%)

73.74 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
61.69
 -0.35% pkg/workloads/manager.go
Jobs
ID Job ID Ran Files Coverage
1 29961439084.1 814
69.04
 GitHub Action Run
Source Files on build 29961439084