MinaProtocol / deb-toolkit / 29956680105

83%

Build Type

push

github

Committed by dkijania

Commit Message

session reversion: rewrite all version operators unconditionally (match bash)

Fixes #12.

deb-session-reversion.sh (whose mina callers invoke it with no flag)
rewrites the old version to the new one across every versioned
dependency constraint on every reversion. deb-toolkit did this only
under --update-deps, and even then only for exact `=` pins, leaving
`>=`/`<<`/etc. alone on the theory that a looser constraint is still
satisfied by a higher version.

That theory fails for mina: reversions are not monotonic (manager.sh
reversions to an arbitrary target, e.g. a fork build 3.4.0-rc2-company
-<hash> down to a clean 3.4.0-rc2). On a downward reversion a stale
`(>= old)` is unsatisfiable and the package will not install.

Changes:
- replace_in_constraint rewrites all Debian relation operators
  (=, <<, <=, >=, >>), matching the operator as a prefix so both
  `(<< X)` and `(=X)` — mina emits both — are handled.
- reversion performs the dependency rewrite unconditionally; the
  --update-deps CLI flag and update_deps manifest field are kept,
  accepted, and ignored (deprecated) so existing callers/manifests
  keep working. The flag now warns.
- rewrite stays constraint-scoped (inside `(...)`), so a version-like
  substring in a package name is never mangled — an improvement over
  the bash bare-substring pass.

Verified against the bash scripts on a realistic downward reversion
with mixed `(=X)`/`(<< X)` formats: control fields are now identical.

Coverage Stats

35 of 37 new or added lines in 4 files covered. (94.59%)

1 existing line in 1 file now uncovered.

1871 of 2250 relevant lines covered (83.16%)

10.61 hits per line