decentraland / sites / 29952847704

96%

push

github

fix: warn when editing an approved hangout will send it back for review (#688)

* fix: warn when editing an approved hangout will send it back for review

when an owner edits an already-approved hangout in a way that re-triggers
moderation on the events backend, the edit form now shows an amber warning
up front.

`hasModeratedContentChanged` mirrors the exact submit payload mapping and
returns true only when name / description / image / x / y / server actually
differ — the same fields the events backend re-moderates on. editing only
date, recurrence, email, or community does not warn. the form hook exposes
`requiresModerationReview` (approved and content changed) and `EventForm`
renders a `ReviewWarningAlert`. copy added to all six locales.

covered by helper unit tests across the field matrix and form tests for the
warning shown / hidden states.

* fix: align approved-edit warning with backend re-moderation parity

addresses review parity notes on the moderation warning:

- extend `hasModeratedContentChanged` to the full backend moderated set
  this form can edit — adds the vertical image and the world/location mode
  alongside name/description/image/coords/server (categories aren't editable
  here, so they stay omitted).
- gate `requiresModerationReview` on the backend's actor-can-approve
  exemption via `useAdminPermissions`, so moderators / self-approvers don't
  see a "will send it back for review" warning for an edit the backend will
  keep approved.

the sanitized-description round-trip case (a non-moderated edit re-queuing a
legacy event whose stored description held markup) is resolved on the
backend (events#986), which now compares the sanitized description on both
sides so the form baseline and the backend agree.

4345 of 4855 branches covered (89.5%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 2 files covered. (100.0%)

10352 of 10437 relevant lines covered (99.19%)

17.88 hits per line