stacklok / toolhive / 29948162085

69%

Build Type

push

github

Committed by web-flow

Commit Message

Add Envoy network-proxy backend behind TOOLHIVE_NETWORK_PROXY=envoy (#5907)

* Add Envoy network proxy backend behind TOOLHIVE_NETWORK_PROXY=envoy

Introduces envoyProxy, which consolidates egress (forward proxy :3128)
and ingress (reverse proxy) into a single container, reducing auxiliary
container count from 3 (Squid: egress + ingress + dns) to 2 (Envoy
combined + dns). Selected via TOOLHIVE_NETWORK_PROXY=envoy; Squid
remains the default.

The gateway block uses two layers: a gateway-deny filter carrying the
resolved GatewayIP (L3) and Docker-internal hostnames (L7), prepended
before the HTTP RBAC allowlist filter. Admin API binds to 127.0.0.1
loopback only. Bootstrap temp files are written at mode 0600.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Fix Envoy config correctness and add architecture doc

Rewrites the Envoy bootstrap generation to produce valid protobuf-JSON:
every typed_config field now carries the required @type URL. Adds the
CONNECT route matcher so HTTPS tunnelling works, fixes ingress listener
to bind 0.0.0.0 inside the container (Docker port forwarding targets the
bridge IP, not the container loopback), switches gateway hostname deny to
prefix matching so host.docker.internal:443 is caught in HTTPS CONNECT,
and adds stdout access logging to both listeners.

Also adds docs/arch/14-envoy-network-proxy.md describing the design,
the comparison with Squid, and known limitations.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Match Squid dstdomain semantics for Envoy egress allowlist

The Envoy allowlist translated AllowHost entries with exact/suffix string
matchers keyed off a "*." prefix, which diverged from the Squid backend in
two ways: Squid uses a leading-dot convention (.example.com) for subdomain
matching, and its dstdomain matches the apex domain too. The prior code
mistranslated .example.com into a useless exact match (silently denying
traffic Squid would allow) and co... (continued)

Coverage Stats

403 of 435 new or added lines in 2 files covered. (92.64%)

285 existing lines in 4 files now uncovered.

76853 of 111227 relevant lines covered (69.1%)

74.8 hits per line