source-academy / py-slang / 29927944717

86%

Build Type

push

github

Committed by web-flow

Commit Message

Keep integers out of the module interface; unify pair/array; fix py2js DataType.ARRAY handling (#307)

* Keep integers out of the module interface

Squashes the full history of this branch's INTEGER work into one commit -
the intermediate commits explored tagging a Python int as DataType.INTEGER
across the module boundary and coercing it back to NUMBER at various points
(scalar args/returns, then array elements), based on an initial misreading
of what was needed. After discussion with Martin, the actual, final design
is simpler and is what this commit leaves in place:

Martin, explicit and final: "'would print 1.0, not 1' is a feature, not a
bug. We should keep integers out of modules." binary_tree's entry() printing
1.0 for a tree built from a Python int is the correct, intended behavior.
A Python int silently becomes DataType.NUMBER (a float) the moment it
crosses into any module, unconditionally - CSE/py2js/PVML's pythonToModule
(the "bigint" case) and PVML's pvmlToModule all convert directly to NUMBER,
with no separate INTEGER tag and no per-position/per-declared-type
exception, including for a value sitiing inside an OPAQUE-wrapped payload.

Net effect versus main, kept:
- GenericDataHandler.closure_call_unchecked now throws on an invalid closure
  identifier instead of silently returning undefined - independent,
  unrelated fix (every caller immediately calls .next() on the result, so
  the previous undefined return was a latent TypeError waiting to happen)
  that happened to be bundled into these commits; kept on its own merits.
- Each engine's moduleToPython/moduleToPvml/WASM's typedToHostValue keeps a
  minimal DataType.INTEGER case, converting to a float, purely for switch
  exhaustiveness over conductor's DataType enum (which permanently has the
  member now that conductor#47/0.7.2 is published) - dead code in practice,
  since nothing in py-slang produces INTEGER anymore.
- @sourceacademy/conductor bumped to ^0.7.2 - conductor#47 is backwa... (continued)

Coverage Stats

4384 of 5459 branches covered (80.31%)

Branch coverage included in aggregate %.

79 of 90 new or added lines in 6 files covered. (87.78%)

1 existing line in 1 file now uncovered.

9447 of 10544 relevant lines covered (89.6%)

178847.72 hits per line