Kikobeats / parse-proxy-uri / 29928461363

100%

push

github

fix: prevent credential corruption in ProxyURL#toString (#21)

* fix: percent-encode credentials in ProxyURL#toString

Decoded username/password were interpolated into toString(), which
corrupted proxy URIs when credentials contained reserved characters
such as @, :, or /. Serialize the URL-encoded credential slots instead
and omit empty userinfo.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* test: use ava default export for CJS compatibility

Ava 8 exposes the test function on the default export under require().

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* refactor: capture encoded credentials in closure for toString

Capture the percent-encoded username/password once in the constructor
instead of reaching into URL.prototype's getter on every toString call.
Simpler, avoids a per-call descriptor lookup, and reads like the
surrounding code.

Also match native URL userinfo formatting: drop the trailing colon when
only a username is present (http://user@host, not http://user:@host).
Adds partial-empty credential regression tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QXEvAnXatmFeJWqzV2a3cq

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

16 of 16 branches covered (100.0%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

74 of 74 relevant lines covered (100.0%)

8.18 hits per line