FlexMeasures / flexmeasures / 29912010644

82%

main: 83%

Pull #2335

github

Merge feat/2113-operation-mode-power-bands: adopt sign-explicit ranges

Reconcile multi-commodity operation modes with the base-branch review change that
renamed the operation-mode power range to sign-explicit consumption-range /
production-range keys and added _operation_mode_signed_band.

- OperationModeSchema: keep the base's consumption_range/production_range fields,
  check_ranges validator and _operation_mode_signed_band helper; drop the old
  power_range field/validator; keep commodity_power_ranges + uniqueness check.
- CommodityPowerRangeSchema: make per-commodity ranges sign-explicit too
  (consumption-range and/or production-range), with the same non-negative /
  through-zero validation.
- storage.py: factor out a shared _signed_range_endpoints core reused by both
  _operation_mode_signed_band (device's own band) and a new
  _operation_mode_commodity_bands, which derives each commodity's directional
  (factor-0, factor-1) signed endpoints aligned to the device's operation-mode factor.
- linear_optimization.py: clarify that device_mode_commodity_ranges carries signed
  (c0, c1) factor-extreme endpoints (sign resolved upstream), not (min, max).
- tests: express the cogeneration unit sign-explicitly (electricity and heat as
  production, gas as consumption), driven through the schema + helpers.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MLCUiSdXDqDBmg8GbYp1B
Signed-off-by: F.N. Claessen <claessen@seita.nl>

62 of 67 new or added lines in 3 files covered. (92.54%)

15559 of 18869 relevant lines covered (82.46%)

0.82 hits per line