kubernetes-sigs / kubebuilder / 29912126993
84%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 103
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.369%. Remained the same
29912126993

push

github

web-flow 
🐛 (go/v4): make scaffolded .dockerignore build on Podman and the classic Docker builder (#5887)

* 🐛 (go/v4): make scaffolded .dockerignore build on the legacy Docker builder

The scaffolded .dockerignore re-included sources with an allow-list (** then
!**/*.go) that relies on BuildKit semantics. On the legacy Docker builder a file
is not re-included while its parent directory stays ignored, so "COPY . ." shipped
only go.mod and go.sum and "go build cmd/main.go" failed with
"package cmd/main.go is not in std".

Also re-include the cmd, api and internal source directories so the legacy builder
receives the sources whose parent directory would otherwise stay ignored. BuildKit
keeps re-including any .go through !**/*.go, so its behavior and build context are
unchanged, and no config, dist or VCS files leak into the context on either builder.

Regenerated the .dockerignore in every sample project.

Ref: https://github.com/kubernetes-sigs/kubebuilder/issues/5886

* 🌱 (go/v4): verify the scaffolded .dockerignore across container tools

Shorten the explanation in the scaffolded .dockerignore to the two lines an end
user needs, and cover the behaviour with tests.

Container tools disagree on whether they descend into an ignored directory to
evaluate a re-include such as "!**/*.go". BuildKit does, the classic Docker
builder and Podman/buildah do not, so the scaffold has to name the source dirs
for the build to work everywhere.

test/verify-docker-build-context.sh builds the builder stage, which is the stage
that consumes the build context, and asserts that it holds every non-test Go
source needed to build the manager and none of the files that must not reach the
image. The new workflow runs it on BuildKit, on the classic builder and on
Podman, against both the testdata sample and a freshly scaffolded project.

8199 of 9718 relevant lines covered (84.37%)

148.43 hits per line

Jobs
ID Job ID Ran Files Coverage
1 29912126993.1 103
84.37
 GitHub Action Run
Source Files on build 29912126993