ben-manes / caffeine / #5675

100%

master: 100%

push

github

Fail loudly on a truncated binary trace

BinaryTraceReader treated any EOFException from readEvent as a clean
end-of-trace, so a trace whose final record was truncated (a partial
last record, or a truncated gzip whose inflater dies mid-record) was
silently accepted and its hit rate reported on incomplete data.

Wrap the stream in a CountingInputStream and, on EOFException, throw
when bytes were consumed since the record started (a partial record)
rather than none (a genuine record boundary). No reader changes: a
clean boundary always throws on the first read, before any byte.

4192 of 4203 branches covered (99.74%)

8471 of 8475 relevant lines covered (99.95%)

1.0 hits per line