raystack / frontier / 29901558340

46%

main: 47%

Build Type

Pull #1790

github

Committed by whoAbhishekSah

Commit Message

fix(auth): only map invalid_grant to 4xx, not all token errors

oauth2 returns a RetrieveError for any non-2xx token endpoint response,
so the earlier check also turned provider 429 and 5xx failures into a
4xx. That would hide a real IdP outage and stop it from paging.

Narrow the check to RFC 6749 "invalid_grant" via a small isInvalidGrantErr
helper, and add unit tests covering invalid_grant, 429, 5xx, misconfig,
and non-oauth2 errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #1790: fix(auth): return 4xx for bad OIDC authorization codes

Coverage Stats

6 of 15 new or added lines in 2 files covered. (40.0%)

38 existing lines in 1 file now uncovered.

17785 of 38476 relevant lines covered (46.22%)

13.36 hits per line