dangernoodle-io / breadboard / 29893642544

96%

push

github

refactor: relocate bb_openapi_validate to host-only (B1-1151) (#996)

bb_openapi_validate() had zero production callers but is the load-bearing
oracle for test_route_fidelity.c and test_sse_schema_fidelity.c, which
assert HTTP/SSE response bodies match their declared OpenAPI schemas — so
it can't simply be deleted without losing that coverage.

BREAKING: bb_openapi_validate() and bb_openapi_validate_err_t are removed
from the public bb_openapi API (components/bb_openapi/include/bb_openapi.h).
Any external consumer calling this symbol must migrate off it; there was no
known downstream user.

- move bb_openapi_validate.c from components/bb_openapi/src/ to
  platform/host/bb_openapi/; it no longer builds under
  idf_component_register, so its 31 cJSON call sites never enter the
  ESP-IDF build graph. Host test builds still compile it because bbtool's
  board-scaffold discovery globs *.c directly under a component's
  platform/<platform>/<name>/ directory from directory structure alone
  (scripts/bbtool/discovery.py / boards.py derive_component) — no
  bbtool-scaffold-hint needed, unlike bb_config's hints (which are
  load-bearing because bb_config's sources are ALSO built by
  idf_component_register for both platforms from one CMakeLists)
- drop json from bb_openapi's PRIV_REQUIRES (verified bb_openapi_emit.c and
  platform/espidf/bb_openapi/bb_openapi_register.c have zero cJSON refs)
- move bb_openapi_validate()/bb_openapi_validate_err_t into a new
  platform/host/bb_openapi/bb_openapi_validate_priv.h private header
- update test_bb_openapi_validate.c, test_route_fidelity.c, and
  test_sse_schema_fidelity.c to include the new private header; both
  fidelity suites keep their existing test bodies unchanged

7426 of 8016 branches covered (92.64%)

Branch coverage included in aggregate %.

12569 of 12731 relevant lines covered (98.73%)

2442.49 hits per line