inveniosoftware-contrib / invenio-sip2 / 29893467828

87%

Build Type

push

github

Committed by PascalRepond

Commit Message

fix(server): mask passwords in SIP2 request logs

SIP2 request messages embed the terminal, patron and login passwords
(fields "AC", "AD", "CO") in clear text. Both the request info log and
the "invalid checksum" error log emitted the raw message, exposing these
credentials in log files and error reporting tools (e.g. Sentry), where
generic password scrubbers do not match the raw wire format.

Add mask_sensitive_data() and redact those fields before logging, in the
error log, the info log and the debug "_sip2" field. Message.dumps() is
left untouched since its "_sip2" value is reused to resend messages.

Co-Authored-By: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

8 of 13 new or added lines in 2 files covered. (61.54%)

4 existing lines in 1 file now uncovered.

1568 of 1795 relevant lines covered (87.35%)

0.87 hits per line