dangernoodle-io / breadboard / 29891238367

96%

push

github

refactor: route update.available REST through bb_data_render() (B1-1053 PR3) (#993)

- bb_ota_check_emit_status_json() (GET /api/update/status, shared by the
  persistent bb_ota_check route and bb_ota_boot's boot-mode on-demand
  route) now renders via bb_data_render() against the "update.available"
  bb_data binding instead of the retired bb_json bb_cache serializer
  (bb_ota_check_serialize(), deleted along with the .serialize slot in its
  bb_cache_config_t -- BB_ERR_UNSUPPORTED discard at bb_ota_check_common.c:949
  is moot now, that call site no longer exists)
- BREAKING: response shape changes from a bare object to the
  {"ts_ms":N,"data":{...}} envelope (mirrors diag.boot's B1-1053 PR1
  cutover); ts_ms is bb_clock_now_ms64() read at render time, not a sample
  time -- bb_data_render() has no notion of one, and bb_ota_check_gather()
  (a pure pass-through over bb_cache) doesn't carry one either
- kept the pre-render bb_cache_update() refresh in emit_status_json():
  verified bb_ota_check_gather() is a pure pass-through, not a recompute --
  dropping the refresh would freeze the response at the last publish_state()
  call, missing a since-mark_check_on_apply() transition or a runtime
  bb_settings_update_check_enabled_set() toggle
- added bb_ota_check_bind() (mirrors bb_diag_boot_bind()'s composition-time
  self-bind pattern), called from bb_ota_check_init() -- B1-1045 bound only
  "log" (examples/floor); update.available had no binding anywhere, and
  binding from init() (not either route-registration call site) covers both
  bb_ota_check_register_init()'s persistent path and bb_ota_boot's boot-mode
  status_check_ensure_init() path with one call site
- dropped bb_json from bb_ota_check's PRIV_REQUIRES (its last use was the
  deleted serializer)
- converted test_wire_desc_producers.c's update.available section from
  parity-diffed-against-the-old-serializer to literal exact-JSON goldens,
  and removed its row from test_bb_cache_fidelity.c's ser... (continued)

7426 of 8016 branches covered (92.64%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 2 files covered. (100.0%)

12569 of 12731 relevant lines covered (98.73%)

2455.07 hits per line