ThePalaceProject / web-patron / 29864885856

82%

push

github

Standardize breadcrumbs for search results collection (PP-4675) (#163)

## Description

<!--- Describe your changes -->
When computing breadcrumbs, the CPW will now consider whether or not the
collection is a search results feed. When that is the case, the
breadcrumbs will now only display the name provided for the catalog root
and "Search." For example, a search conduced from a "New & Noteworthy"
collection lane will have its name dropped:

`All Books / New & Noteworthy / Search` -> `All Books / Search`

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
When conducting a search from any page, the breadcrumbs previously
included the lane from where the search originated. This incorrectly
suggested that the search would be scoped to items within that
collection. Searches from any page are performed on the entire catalog.
Displaying the breadcrumbs as Catalog Root / "Search" provides a more
accurate description of the search results to the user.

[Jira PP-4675](https://ebce-lyrasis.atlassian.net/browse/PP-4675)

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
- Manually tested in Firefox, Chrome, and Safari
- Unit tests check for presence of lane when running
`computeBreadcrumbs`

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

225 of 260 branches covered (86.54%)

Branch coverage included in aggregate %.

383 of 427 relevant lines covered (89.7%)

29.93 hits per line