NodeBB / NodeBB / 29862434892

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix: hide unenterable rooms from the chat list (#14483)

* fix: hide unenterable rooms from the chat list

getRecentChats/searchRecentChats only filtered rooms by whether the room
object existed, while loadRoom additionally requires the viewer to be a
member of a private room. A private room the viewer is not a member of
therefore showed up in the chat list as an empty, unenterable entry
(blank name, no teaser, 404 on click).

Fetch the viewer's room membership alongside the other list data and drop
private rooms the viewer is not in, mirroring the visibility check in
Messaging.loadRoom so the list only shows rooms that can actually be opened.

* fix: self-heal dangling room references in the chat list

Following review feedback: instead of only hiding rooms the viewer can no
longer open, collect their ids while filtering and remove them from the
user's chat room and unread sets after processing, so the dangling
references clean themselves up on the next list load.

Coverage Stats

14196 of 19333 branches covered (73.43%)

3 of 7 new or added lines in 1 file covered. (42.86%)

4 existing lines in 1 file now uncovered.

29437 of 34459 relevant lines covered (85.43%)

3339.93 hits per line