NodeBB / NodeBB / 29853022428

85%

push

github

fix(activitypub): recognize non-ASCII webfinger handles (#14466)

* fix(activitypub): recognize non-ASCII webfinger handles

webfingerRegex used \w, which only matches ASCII word characters, so
isWebfinger() returned false for any handle whose user portion contains
non-ASCII characters (e.g. Turkish ö/ü/ğ/ş/ç/ı). Such handles were then
never treated as webfinger addresses: user/category search could not
resolve them, and actors.assert() cached them as webfinger failures.

Match unicode letters, numbers and combining marks explicitly instead.

* fix(activitypub): sync webfinger regex in frontend search module

14197 of 19329 branches covered (73.45%)

29442 of 34456 relevant lines covered (85.45%)

3339.67 hits per line