eclipsesource / jsonforms / 29847842784

84%

master: 84%

Build Type

Pull #2585

github

Committed by sdirix

Commit Message

core: harden setDataAt/unsetDataAt against edge cases

Improvements on top of the lodash/fp/set replacement:

- Store "__proto__" segments as own properties via defineProperty and
  traverse own properties only, so such keys neither corrupt the
  container's prototype nor get dropped. Clone containers key-by-key
  because downleveled object spreads assign instead of define.
- Read the updater's old data with resolveData instead of lodash get,
  so reads use the same literal path semantics as writes.
- Fall back to lodash's index heuristic when creating missing
  containers without schema type information.
- Match lodash's isIndex semantics with a strict index regex instead
  of Number() coercion.
- Avoid strict-mode TypeErrors when unsetting non-index array
  properties (e.g. "length") and return the same reference when
  there is nothing to unset.
- Treat an empty path as addressing the root, and replace non-object
  root data instead of spreading it.

Also documents the path semantics change in MIGRATION.md and adds unit
tests for setDataAt/unsetDataAt.

Pull Request Pull Request #2585: fix: refactor update data to avoid lodash issues

Coverage Stats

12532 of 31921 branches covered (39.26%)

80 of 81 new or added lines in 3 files covered. (98.77%)

40 existing lines in 10 files now uncovered.

20318 of 24106 relevant lines covered (84.29%)

33.65 hits per line