openego / eDisGo / 29840670433

83%

dev: 84%

Pull #719

github

fix: align flexibility_bands reads to the timeindex in the OPF builder

_build_electromobility and _build_component_timeseries's electromobility
branch read edisgo_obj.electromobility.flexibility_bands positionally
(.iloc[0] for static bounds, .values.tolist() for the full per-timestep
column) instead of aligning to edisgo_obj.timeseries.timeindex first.
This was only safe because the standard run pipeline always finalizes
the timeindex before building bands and running optimize - an implicit
ordering convention, not something either function or the validator
enforced. Breaking that ordering would silently feed wrong/misaligned or
length-mismatched OPF input to PowerModels/Julia rather than raising a
clear error.

Both functions now explicitly select flexibility_bands[key].loc[timeindex]
(or .loc[timeindex, flexible_cps]) before any positional access, mirroring
the alignment pattern already established in
Electromobility.get_flexibility_bands (#703). A genuine mismatch now
raises KeyError immediately instead of silently producing wrong data.

No separate length assertion against pm["time_series"]["num_steps"] was
needed: to_powermodels always builds psa_net via
edisgo_object.to_pypsa() with no explicit timesteps override, so
psa_net.snapshots is always exactly edisgo_obj.timeseries.timeindex here
- the .loc[timeindex] alignment already guarantees the length matches.

Fixes #718.

3 of 3 new or added lines in 1 file covered. (100.0%)

9514 of 11430 relevant lines covered (83.24%)

0.83 hits per line