facebookincubator / TTPForge / 29841279469
57%
main: 67%

LAST BUILD BRANCH: export-D113022608
DEFAULT BRANCH: main
Ran
Jobs 1
Files 80
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 56.628%. First build
29841279469

Pull #627

github

facebook-github-bot 
Fix Windows fbpkg build: pty.Winsize fields are uint16, not uint

Summary:
Context: The `blackbird/ttpforge_binaries` Conveyor pipeline builds `blackbird.one_platform.ttpforge_{linux,linux_arm64,macos,windows_x86_64}` in a single release and preserves them via one shared `preserve_v1` node. Since 2026-06-02 every release (R3470–R3489+) has been FAILED, blocking `preserve_v1`, so no package — including the healthy `ttpforge_linux` — has been promoted to a new DEFAULT. The 48-day-old default triggered a stale-code UBN (T279859531, the 3rd such recurrence).

Motivation: The only failing node is `fbpkg Build Node (blackbird.one_platform.ttpforge_windows_x86_64)`. It fails to compile with:
  winsize_windows.go:27: cannot use uint(rows) (value of type uint) as uint16 value in struct literal

`newWinsize` was split into build-tagged helpers in D106692973 under the assumption that `pty.Winsize.Rows/Cols` are `uint` on Windows but `uint16` on Unix. That is false for the fbcode-vendored `github.com/creack/pty`: both `winsize_unix.go` and `winsize_unsupported.go` declare the fields as `uint16` on every platform. The Windows-tagged helper's `uint` cast therefore never compiled under the internal buck `opt-win` target. (The GitHub Actions cross-compile check added in that diff passed against the upstream module, hiding the break from the internal build.)

This diff: change `winsize_windows.go` to cast to `uint16`, matching `winsize_unix.go` and the actual struct field type. This unblocks the Windows build node, which unblocks the shared `preserve_v1` node and lets the pipeline resume preserving fresh DEFAULT versions of all four ttpforge packages.

___

Reviewed By: sriharic-meta

Differential Revision: D113022608
Pull Request #627: Fix Windows fbpkg build: pty.Winsize fields are uint16, not uint

3238 of 5718 relevant lines covered (56.63%)

15.31 hits per line

Jobs
ID Job ID Ran Files Coverage
1 29841279469.1 80
56.63
 GitHub Action Run
Source Files on build 29841279469