containernetworking / plugins / 29832297481

53%

master: 55%

Pull #1279

github

dhcp: send DHCPRELEASE with the client IP addr as ciaddr

The dhcp IPAM plugin sends DHCPRELEASE packets with 0.0.0.0 as the IP source
address instead of the client's assigned IP.

This violates RFC 2131 section 4.4.4 and causes DHCP servers (e.g. dnsmasq) to
silently ignore the release. Leases are never freed — they only expire via
timeout.

By using the `nclient4.WithUnicast()` option, the client will stop using
a raw packet socket which constructs IP headers with 0.0.0.0 as the source.

Using src IP 0.0.0.0 is appropriate for DHCPDISCOVER (no address assigned yet)
but wrong for DHCPRELEASE.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>

0 of 8 new or added lines in 1 file covered. (0.0%)

5005 of 9533 relevant lines covered (52.5%)

27.84 hits per line