nvidia-holoscan / holoscan-cli / 29831077735

79%

main: 79%

Build Type

Pull #202

github

Committed by wyli

Commit Message

fix: parse HOLOSCAN_CLI_BUILD_LOCAL as a boolean, not Python truthiness

Several commands chose local vs. container execution with a bare
truthiness check:

    args.local or os.environ.get("HOLOSCAN_CLI_BUILD_LOCAL")

Any non-empty string is truthy in Python, so `0`, `false`, and `no`
were treated as True. A user (or AI agent) setting
`HOLOSCAN_CLI_BUILD_LOCAL=0` to request container execution silently got
a host build instead.

Add `is_env_flag_true()` in utils/text.py to parse a raw env/config value
against the shared false-value set ("false", "no", "n", "0", "f", "off";
blank/None is false), and a `is_local_build_requested()` helper in
utils/holohub.py that applies it uniformly across the CLI flag, the
process environment, and any mode-config `env` mappings. Use it in build,
run, install, package, and test so a falsey flag no longer forces host
execution.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Pull Request Pull Request #202: fix: parse HOLOSCAN_CLI_BUILD_LOCAL as a boolean, not Python truthiness

Coverage Stats

17 of 17 new or added lines in 7 files covered. (100.0%)

25 existing lines in 1 file now uncovered.

3136 of 3988 relevant lines covered (78.64%)

0.79 hits per line