TheKevJames / coveralls-python / 61c3f405-9d39-4225-a0ce-e5c678b4426c

95%

master: 97%

push

circleci

refactor!: audit lint suppressions and drop the custom exception

Audit and remove disabled lint checks across the project:

- Remove the stale too-many-public-methods pylint disable on Coveralls
  (the class has well under the threshold of public methods).
- Use pathlib.Path.touch() instead of open().close() in the git tests,
  dropping a consider-using-with disable.
- Replace the custom CoverallsException with the most relevant builtin
  exceptions and delete coveralls/exception.py: ValueError for invalid
  configuration, TimeoutError for request timeouts, and RuntimeError for
  other failures. The class existed largely to give exceptions value
  equality for test assertions; those assertions now inspect the raised
  exception directly.
- Specify encoding='utf-8' on all text file I/O and drop the
  bad-file-encoding / unspecified-encoding pylint disables (the
  deliberately ISO-8859-15 nonunicode/ fixture is excluded from pylint,
  consistent with the other python hooks).
- Re-enable the tryceratops pre-commit hook, unblocked by the exception
  removal, and fix the one TRY401 it flagged: _run_action no longer
  passes the exception object to log.exception, which already records it
  via exc_info.

BREAKING CHANGE: coveralls.exception.CoverallsException has been removed.
Code that imported or caught it must catch the builtin exceptions raised
instead (ValueError, TimeoutError, or RuntimeError).

changelog:
The custom ``coveralls.exception.CoverallsException`` has been removed.
coveralls-python now raises standard builtin exceptions: ``ValueError``
for invalid configuration, ``TimeoutError`` for request timeouts, and
``RuntimeError`` for other failures. If your code catches
``CoverallsException``, update it to catch these builtins instead.

154 of 164 branches covered (93.9%)

Branch coverage included in aggregate %.

17 of 18 new or added lines in 5 files covered. (94.44%)

529 of 555 relevant lines covered (95.32%)

5.72 hits per line