jhheider / mdtask / 29821311465

85%

Build Type

push

github

Committed by web-flow

Commit Message

Encapsulate execution behind run/run_captured/run_agent (0.3) (#11)

Narrow mdtask-core's public API so consumers deal only in jobs, their
metadata, and running them, never in execution mechanics. The Task struct
is renamed Job; its script, lang, opts, and env fields become internal, as
do Invocation, TaskFile::invocation, interpreter, dependency_order, bind,
substitute, parse_args, and Job::inherits_cwd/script_arg_templates. No
consumer sees a program, argv, interpreter, or temp file.

Three entry points run a job and its Requires: chain:

  run           inherits stdio (the CLI, streaming)
  run_captured  aggregates stdout/stderr across the chain (embedders)
  run_agent     the agent gate: allowlist, within-file dependency
                resolution, and the {{ arg }} injection guard, captured

The two previously found RCEs stay fixed: run_agent resolves the Requires:
chain within the allowed target's own file (so a nearer untrusted task file
cannot shadow a dependency), and refuses a target that raw-templates a
declared arg. Both are covered by regression tests in lib.rs and, through
the tool path, in mcp.rs.

The CLI run loop collapses to mdtask_core::run; mcp.rs run_task delegates to
run_agent and list_tasks to agent_jobs, with all security logic moved to
core. The lint subcommand (shellcheck) is removed entirely. The fixture test
now drives the public surface (parse, jobs(), run_captured, run_agent). Both
crates bump to 0.3.0.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

298 of 369 new or added lines in 3 files covered. (80.76%)

4 existing lines in 2 files now uncovered.

940 of 1172 relevant lines covered (80.2%)

6678.02 hits per line