hyperledger / fabric-x-committer / 29819891022
91%
main: 91%

LAST BUILD BRANCH: skill-dev
DEFAULT BRANCH: main
Ran
Jobs 3
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.574% (+0.1%) from 91.467%
29819891022

Pull #694

github

liran-funaro 
[skills] Add development skill for writing new Go code

- New feature
- Documentation update

- Add a `development` skill capturing this repo's conventions for writing new Go
  code: code ordering (caller-before-callee, struct grouping, inline single-use
  helpers), concurrency (`errgroup` + `utils/channel` wrappers), Go 1.26 idioms,
  error handling, and logging — plus a `references/service-construction.md`
  blueprint for services/config/metrics.
- Wire the skill set together: `pr-review` now reads the `development` and `tests`
  skills and flags deviations as findings; `tests` gains a "Reusing Test Fixtures &
  Helpers" section (repo harnesses + `fabric-x-common` `testcrypto`/`tlsgen`).
- Fix stale references in `AGENTS.md` and `guidelines.md`: `logger.ErrorStackTrace(err)`
  does not exist — the real idiom is `logger.Errorf("%+v", err)`; also correct the
  `gprcerror` -> `grpcerror` typo in `guidelines.md`.
- Trim `AGENTS.md`'s now-duplicated convention prose to a summary that points at the
  `development` skill as the source of truth.

Validated with a with-skill vs. baseline comparison across 6 coding tasks; the skill
improved adherence on the subtle conventions a capable baseline still missed
(context-aware `channel.NewReader/Writer`, `%+v` boundary logging).

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
Pull Request #694: [skills] Add development skill for writing new Go code

10324 of 11274 relevant lines covered (91.57%)

34251.09 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
88.31
 -2.6% service/vc/committer.go
3
84.84
 -1.23% service/sidecar/relay.go
3
91.27
 -1.31% service/vc/validator_committer_service.go
2
84.7
 -0.55% service/vc/database.go
Jobs
ID Job ID Ran Files Coverage
1 core-db-test - 29819891022.1 98
46.08
 GitHub Action Run
2 db-test - 29819891022.2 127
79.4
 GitHub Action Run
3 unit-test - 29819891022.3 91
85.35
 GitHub Action Run
Source Files on build 29819891022