source-academy / plugins / 29809910401

98%

feat/add-init-infra: 67%

push

github

Fix stepper plugin directory resolving to a nonexistent .js entry (#59)

* Fix plugin directory resolving external plugins to a hardcoded .js entry

generateManifest() hardcoded "index.js" as every external plugin's web
resolution path in the published directory.json. The stepper plugin's
build (wrap.mjs) emits "index.mjs", so the live directory.json has
pointed at a 404 since the stepper package was added - silently
breaking dynamic loading of the stepper web plugin (frontend's
resolveWebPluginUrl gets a URL back, import() 404s, the error is
caught and only console.warn'd, so the host plugin never registers its
tab and the Stepper side panel is stuck on "Loading the stepper...").

Derive the entry filename from the plugin's own package.json
(main/module) instead of assuming an extension.

* Guard main/module against non-string types before pathlib.basename

package.json is untyped JSON, so a malformed or unusually-shaped
main/module field could otherwise throw a TypeError and crash the
build. Addresses Gemini Code Assist review feedback on #59.

---------

Co-authored-by: Shrey Jain <“shreyjain5132@email.com>

43 of 46 branches covered (93.48%)

Branch coverage included in aggregate %.

103 of 103 relevant lines covered (100.0%)

4.94 hits per line