NodeBB / NodeBB / 29763692776

85%

push

github

fix: don't show bookmark alert when there is nothing to return to (#14476)

The "click here to return to the last read post" alert was appearing in
topics the user never read past the first post, and clicking it simply
scrolled to the current position.

Two client-side issues caused this:

- The guest/localStorage path in updateUserBookmark stored a bookmark
  unconditionally, so merely opening a topic at post 1 saved
  `bookmark = 1`. Mirror the server-side check in
  SocketTopics.bookmark and only save when the index is past
  bookmarkThreshold.

- handleBookmark showed the alert whenever any bookmark existed, even
  when the current post index was already at or past it. Only show the
  alert when the bookmark points ahead of the current position.

14196 of 19329 branches covered (73.44%)

29438 of 34456 relevant lines covered (85.44%)

3360.48 hits per line