benrr101 / node-taglib-sharp / 54407872

93%

Build Type

push

appveyor

Committed by web-flow

Commit Message

[ID3v2] Standardize on fromFields (#142)

* CommentsFrame.fromFields

* EventTimeCodeFrame.fromFields

* MusicCdIdentifierFrame, PlayCountFrame, PopularimeterFrame, PrivateFrame

* In progress changes for genre frame

* TermsOfUseFrame, TextInformationFrame, UniqueFileIdentifierFrame, UnknownFrame, UnsynchronizedLyricsFrame, UrlLinkFrame and some fixes to previous ones.

* Break inheritance of User/TextInformationFrame, and User/UrlLinkFrame. Rename text in Url frame to url

* Patch up genre frame and tests

* All unit test passing again.

* Make the get/set halpers private, remove the associated unit tests

* Addressing :robot: comments

* Addressing :robot: comments, 2

* Addressing :robot: comments, 3

* Addressing :robot: comments, 4

* Addressing :robot: comments, 5

* Addressing :robot: comments, 6

Coverage Stats

3347 of 4215 branches covered (79.41%)

Branch coverage included in aggregate %.

865 of 872 new or added lines in 40 files covered. (99.2%)

4 existing lines in 3 files now uncovered.

27247 of 28771 relevant lines covered (94.7%)

474.43 hits per line