TheKevJames / coveralls-python / 42298608-0ada-4bf2-a6bc-a74e2f5a8a3e

94%

master: 96%

Build Type

Pull #755

circleci

Committed by TheKevJames

Commit Message

refactor(config)!: model resolved configuration as a typed Config

resolve() now returns a typed Config dataclass instead of an untyped dict.
Config separates API payload fields from client-behaviour settings, exposes
to_payload() as the enforced payload boundary and request_timeout as the
resolved (connect, read) tuple, and validates the timeout family at
construction. api.py consumes Config by attribute and is now type-checked.

changelog:
Resolved configuration is now a typed ``Config`` object. **Breaking (library
API):** ``Coveralls.config`` is a ``Config`` dataclass rather than a ``dict`` --
read values by attribute (``cover.config.service_name``) instead of by key
(``cover.config["service_name"]``). Unrecognised keys in ``.coveralls.yml`` are
now ignored with a warning instead of being silently accepted.

Pull Request Pull Request #755: refactor(config): model resolved configuration as a typed Config

Coverage Stats

132 of 142 branches covered (92.96%)

Branch coverage included in aggregate %.

82 of 82 new or added lines in 2 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

445 of 472 relevant lines covered (94.28%)

5.66 hits per line