TheKevJames / coveralls-python / 29759020625

93%

master: 96%

Pull #754

github

refactor(config)!: resolve every source through one uniform pipeline

Replace the ad-hoc per-service loaders (positional tuples, three different
pull-request parsers, the _coveralls_host/_token_required attrs, and call-time
os.environ reads for host/SSL) with a single resolve() that merges the CI
environment, COVERALLS_* env vars, the config file, and explicit overrides in
one documented precedence order. CI detection returns a uniform dict and
pull-request numbers share one trailing-integer helper.

token_required stays a guard, not a user-facing setting: only CI detection
(e.g. TravisCI) and the explicit constructor argument may waive it, AND-ed so
any waiver sticks and the default True cannot re-impose it. A token_required
key in the config file or env is ignored, so a committed .coveralls.yml can't
silently disable the check.

changelog:
Configuration from every source -- CI detection, ``COVERALLS_*`` env vars, the
config file, and explicit overrides -- is now resolved through one pipeline with
a single documented precedence order (later wins), replacing the per-service
special cases. **Breaking (library API):** ``Coveralls()`` no longer accepts
``service_name`` as a dedicated argument; pass it as a keyword override like any
other field (e.g. ``Coveralls(service_name="travis-pro")``). Positional calls
such as ``Coveralls(True, "travis-pro")`` must be updated.

131 of 142 branches covered (92.25%)

Branch coverage included in aggregate %.

123 of 127 new or added lines in 2 files covered. (96.85%)

423 of 451 relevant lines covered (93.79%)

4.69 hits per line