TheKevJames / coveralls-python / 29754769999

93%

master: 96%

Pull #754

github

refactor(config)!: resolve every source through one uniform pipeline

Replace the ad-hoc per-service loaders (positional tuples, three different
pull-request parsers, the _coveralls_host/_token_required attrs, and call-time
os.environ reads for host/SSL) with a single resolve() that merges the CI
environment, COVERALLS_* env vars, the config file, and explicit overrides in
one documented precedence order. CI detection returns a uniform dict,
pull-request numbers share one trailing-integer helper, and token_required is
AND-ed across sources: any source may waive it, none may re-impose it.

changelog:
Configuration from every source -- CI detection, ``COVERALLS_*`` env vars, the
config file, and explicit overrides -- is now resolved through one pipeline with
a single documented precedence order (later wins), replacing the per-service
special cases. **Breaking (library API):** ``Coveralls()`` no longer accepts
``service_name`` as a dedicated argument; pass it as a keyword override like any
other field (e.g. ``Coveralls(service_name="travis-pro")``). Positional calls
such as ``Coveralls(True, "travis-pro")`` must be updated.

133 of 144 branches covered (92.36%)

Branch coverage included in aggregate %.

124 of 128 new or added lines in 2 files covered. (96.88%)

424 of 452 relevant lines covered (93.81%)

4.69 hits per line