vocdoni / saas-backend / 29747085882

62%

Pull #583

github

chore(api): /processes migration cleanup — deprecations, RESTful shapes, jobs/apikeys consolidation, param standardization (#582)

* chore(processes): deprecate legacy /process endpoints; add missing /processes replacements

Mark every legacy single-election /process, CSP /process/bundle, and org-level
process list endpoint @Deprecated in swagger (21 operations → deprecated: true),
now that the multi-question /processes API (#571) supersedes them. POST /vote is
shared and untouched.

Add the three /processes replacements for capabilities that had no equivalent
yet, so nothing is deprecated without an alternative:
- DELETE /processes/{processId}: delete a draft (rejects published), Manager/Admin.
- POST /processes/{processId}/participants/check: Manager/Admin lookup of org
  members by field intersected with the census, with per-question voted status.
- POST /processes/{processId}/sign-info: a voter's per-question consumed address,
  nullifier and timestamp (the /processes form of the single-election sign-info).

Endpoints that already have /processes equivalents (auth, auth/resend, sign,
weight, check, participant info, create/get/update/publish/status/results/list)
are deprecated only. Metadata is intentionally dropped (handled by the new API).

Reuses existing helpers (authorizeStatusChange, OrgMembersByField,
CensusParticipantsByMemberIDs, MembersWithUsedCSPProcess, CSPProcessByUserAndProcess,
state.GenerateNullifier). Tests: TestVotingProcessDelete and TestProcessCSP
(extended with sign-info + participants/check on a real consumed vote).

* docs(processes): document the /processes CSP voter auth flow in swagger

The process-scoped CSP handlers (ProcessAuthHandler, ProcessAuthResendHandler,
ProcessSignHandler, ProcessWeightHandler, ProcessCheckHandler) were registered
and working but had no swagger annotations, so the OpenAPI spec never described
the voter auth/sign/weight/check flow for the new /processes API. With the
legacy /process/bundle CSP e... (continued)

1566 of 2652 new or added lines in 38 files covered. (59.05%)

11798 of 18897 relevant lines covered (62.43%)

45.45 hits per line