hyperledger / fabric-x-committer / 29747335649

91%

Build Type

push

github

Committed by web-flow

Commit Message

[verifier] add SnapshotEndorsement/CheckpointEndorsement policy parsing and wiring (#683)

#### Type of change

- New feature
 
#### Description

- policy.ParseChannelPolicy(bundle, path) resolves a named channel
policy from the PolicyManager. policy.SystemNamespacePolicies lists the
{NamespaceID, PolicyPath} pairs for all three config-block policies
(_meta/LifecycleEndorsement, _snapshot/SnapshotEndorsement,
_checkpoint/CheckpointEndorsement) so callers loop over one table
instead of three near-identical named wrappers.
- createVerifiers's config-update branch loops SystemNamespacePolicies,
replacing three copy-pasted parse blocks.
- ValidateConfigTx loops the same table, so a config tx missing any of
the three policies (not just LifecycleEndorsement) is now rejected at
ingest time instead of only failing later inside the verifier.
- validateNamespaceIDInPolicy now also rejects committerpb.
SnapshotNamespaceID/CheckpointNamespaceID for ordinary ns__meta
namespace-policy updates, closing the gap where an operator/attacker
could otherwise overwrite the config-block-derived _snapshot/
_checkpoint verifiers via an ordinary _meta transaction.
- verifyRequest already does exact-key lookup (verifiers[ns.NsId]),
which already covers _snapshot/_checkpoint; no change needed (T033).

Tests:
- policy_test.go: TestParseChannelPolicy is table-driven over
SystemNamespacePolicies (lifecycle/snapshot/checkpoint share one test,
placed where the old lifecycle-only test used to live);
TestParsePolicyItem's invalid-namespace cases extended with
_snapshot/_checkpoint.
- verify_test.go: TestCreateVerifiersConfigNamespaces asserts
createVerifiers produces exactly the namespaces listed in
SystemNamespacePolicies after a config update, guarding the shared loop
against silently dropping an entry.

#### Additional details (Optional)

Negative case (policy absent in config block) deferred for
ValidateConfigTx/ParseChannelPolicy unit tests: fabric-x-common's test
config generator... (continued)

Coverage Stats

11 of 16 new or added lines in 2 files covered. (68.75%)

33 existing lines in 7 files now uncovered.

10449 of 11414 relevant lines covered (91.55%)

43174.87 hits per line