Qiskit / qiskit / 29736120358

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix `sx` resynthesis of negative angles in `CommutativeCancellation` (#16599) (#16615)

* Fix `sx` resynthesis of negative angles in `CommutativeCancellation`

`%` maintains the sign of the left operand, so `0..(num_sx as i64 % 4)`
is an empty iterator for non-positive `num_sx`.  If the calculated
rotation angle was negative (such as from a chain of `sxdg`),
non-identity, and we go down the `sx`-like synthesis path, we would
miscompile.

This is a minimal fix to be backport stable, rather than a greater
reworking.

Introduced in 91081cc6d3: Add additional Z and X rotation gate handling
to CommutativeCancellation (#16191)

* Use `ddt` test parametrisaion

(cherry picked from commit 33d90a986)

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

112800 of 128695 relevant lines covered (87.65%)

997328.83 hits per line