Qiskit / qiskit / 29733301808

88%

main: 88%

Build Type

Pull #16615

github

Committed by mergify[bot]

Commit Message

Fix `sx` resynthesis of negative angles in `CommutativeCancellation` (#16599)

* Fix `sx` resynthesis of negative angles in `CommutativeCancellation`

`%` maintains the sign of the left operand, so `0..(num_sx as i64 % 4)`
is an empty iterator for non-positive `num_sx`.  If the calculated
rotation angle was negative (such as from a chain of `sxdg`),
non-identity, and we go down the `sx`-like synthesis path, we would
miscompile.

This is a minimal fix to be backport stable, rather than a greater
reworking.

Introduced in 91081cc6d3: Add additional Z and X rotation gate handling
to CommutativeCancellation (#16191)

* Use `ddt` test parametrisaion

(cherry picked from commit 33d90a986)

Pull Request Pull Request #16615: Fix `sx` resynthesis of negative angles in `CommutativeCancellation` (backport #16599)

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

18 existing lines in 3 files now uncovered.

112780 of 128695 relevant lines covered (87.63%)

999387.94 hits per line