29732760094
91%

Ran 20 Jul 2026 09:50AM UTC

Jobs 3

Files 129

Run time 1min

Badge

Embed ▾

Committed 20 Jul 2026 09:47AM UTC coverage: 91.716% (+0.1%) from 91.575%

Build # 29732760094

Build Type

push

github

Committed by

web-flow

Commit Message

[test] fix flaky TestSignatureVerifierManagerPolicyUpdateAndRecover (#677)

#### Type of change

- Bug fix
- Test update
 
#### Description

Batch submission ran inside require.Eventually/require.Never conditions.
testify runs the condition in its own goroutine and, once waitFor
elapses, returns without waiting for it. submitTxBatch blocks on a full
input channel, so a condition that submitted leaked a goroutine past the
assertion that then (1) submitted stray batches into a later phase of
the test and (2) raced on the reassigned verifierStreams variable (an
observed data race). The stray flooding also kept signVerifier[0] parked
on a channel write, so a stopped server went undetected within the 30s
window and the connection metric stayed Connected.

Submit batches from a dedicated background goroutine that is started
before, and stopped after, each require.Eventually/require.Never, and
keep the conditions side-effect-free (pure reads of atomics and stable
locals). t.Cleanup tears the submitter down even if the test fails
first.

#### Related issues

- resolves #615

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

10451 of 11395 relevant lines covered (91.72%)

45062.51 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	94.79	1.9%	service/coordinator/signature_verifier_manager.go
2	94.67	-0.82%	service/coordinator/coordinator.go
2	85.76	-0.68%	service/query/batcher.go
1	94.17	-0.83%	mock/coordinator.go
1	86.42	-1.23%	loadgen/adapters/verifier.go
1	80.33	-1.64%	utils/utils.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	unit-test - 29732760094.1	20 Jul 2026 09:53AM UTC	93	83.65	GitHub Action Run
2	db-test - 29732760094.2	20 Jul 2026 09:52AM UTC	129	79.92	GitHub Action Run
3	core-db-test - 29732760094.3	20 Jul 2026 09:50AM UTC	100	45.16	GitHub Action Run

hyperledger / fabric-x-committer / 29732760094
91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29732760094

hyperledger / fabric-x-committer / 29732760094 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 29732760094

hyperledger / fabric-x-committer / 29732760094
91%

README BADGES
x