vocdoni / vocdoni-node / 29729250699

63%

Build Type

Pull #1422

github

Committed by web-flow

Commit Message

feat: batch transaction endpoint (POST /chain/transactions/batch) (#1420)

* feat(api): add POST /chain/transactions/batch

Submit multiple pre-signed transactions in one call, in order. Solves the
sequencing pain of creating several dependent processes: the account nonce and
the ProcessIndex-derived electionID only advance on commit, so today a client
must wait for A to commit before it can build B with the right nonce/id.

Behavior: ordered, fail-fast. The first transaction that fails to submit goes to
`failed` and submission stops; the remaining items go to `pending` (they share
the sender's now-broken nonce sequence and cannot commit). Successfully-broadcast
items go to `submitted`. Every input item is returned in exactly one group, and
each NewProcess item carries its predicted `processId` (computed server-side via
processid.BuildProcessID with a per-creator positional delta, matching what the
chain assigns in ordered commit).

`submitted` means mempool-accepted, NOT block-confirmed — documented so callers
confirm on-chain and retry. The grouping/fail-fast logic is factored into
classifyTransactionBatch (injectable submit/id funcs) and unit-tested.

* feat(apiclient): add SendTxBatch for the batch endpoint

Thin client for POST /chain/transactions/batch: submit several marshaled
SignedTx at once and get back the submitted/failed/pending grouping. Callers
build the transactions with contiguous nonces (and predicted processIds).

* api: address review comments on the batch tx endpoint

- Split the shared Transaction type out of the batch contract: request items use a
  dedicated TransactionPayload{payload} (documented, not swaggerignore) and response
  items use a dedicated TransactionBatchItem{hash,processId,code,error}. This fixes
  the OpenAPI request schema (payload was omitted) and tightens both contracts; the
  Error field is no longer bolted onto the shared Transaction type.
- Return a dedicated ErrTransactionBatchEmpty (4060) for an empty b... (continued)

Pull Request Pull Request #1422: chore: promote main → release-lts-1

Coverage Stats

483 of 671 new or added lines in 8 files covered. (71.98%)

17 existing lines in 2 files now uncovered.

17260 of 27445 relevant lines covered (62.89%)

37336.25 hits per line