johanjoensson / impurityModel / 29706824758

91%

Build Type

push

github

Committed by johanjoensson

Commit Message

Make ruff and mypy clean across the package

ruff goes 793 -> 0 and mypy 218 -> 0 ("Success: no issues found"), so the whole
`make check` gate (ruff + black + mypy) is green alongside the pre-commit hooks.

Mechanical ruff fixes: import sorting (I001), unused imports (F401), unused
noqa (RUF100), set/dict comprehensions (C4xx), unused unpacked variables
(RUF059, renamed to _), unused loop variables (B007), loop-variable rebinding
(PLW2901, renamed to *_raw), collapsible ifs (SIM102/108), long lines (E501,
wrapped comments/docstrings/f-strings), and ambiguous unicode in comments and
docstrings (RUF002/003, en-dash/minus/times -> ASCII).

Genuine defects the linters surfaced, fixed rather than silenced:
- F811: three duplicated test definitions in test_manybody_basis.py meant the
  earlier copy silently never ran. Removed the true duplicates and renamed the
  serial test_state_mpi (comm=None, no mpi marker) to test_state.
- F821: mpi_comm.py referenced ManyBodyBlockState from annotations without
  importing it.
- F841: eigensolvers.py computed max_subspace_blocks (and num_wanted) and never
  passed them to any solver -- dead since a refactor.
- A001/A002: op_parser.py shadowed the `str` builtin as a parameter it also
  rebound; renamed to `text`.

Type fixes for mypy: accurate Optional/union signatures, annotations for
otherwise-uninferable containers, @overload for Basis.contains (its return type
depends on whether it is handed one state or many), Iterator (not Iterable)
where next() is called, and explicit None-narrowing asserts in the MPI paths of
basis_split.py/gf_units.py where the invariants hold but are not visible to the
checker. manybody_basis.py drops a dead pre-3.10 collections fallback.

greens_function.py keeps its backward-compat re-export block, now marked
`# noqa: F401`: those names are imported purely so `greens_function.X` keeps
resolving after the gf_primitives/gf_convergence/gf_shift_recycling split, and
an unannotated `ruff --fix` s... (continued)

Coverage Stats

395 of 439 new or added lines in 89 files covered. (89.98%)

9 existing lines in 3 files now uncovered.

20312 of 22646 relevant lines covered (89.69%)

0.9 hits per line