dangernoodle-io / breadboard / 29706158229

96%

push

github

feat: warn when a format-registry consumer is composed with zero serialize backends (#946)

B1-985 (precedent B1-981): detect real call sites instead of name/REQUIRES
heuristics -- a component is a format-registry CONSUMER only if its C
sources call bb_serialize_format_render()/bb_serialize_format_get_render()/
bb_serialize_format_get_parse(), and a BACKEND only if its sources call
bb_serialize_format_register(). Both checks are detected INDEPENDENTLY (a
component can legitimately be both) over comment-stripped source text --
REQUIRES bb_serialize alone (pulled in purely for the bb_serialize_desc_t
type by bb_tcp_client/bb_mqtt_client/bb_http_client/bb_meminfo/bb_system)
no longer false-positives, a non-registering bb_serialize_*-prefixed helper
no longer false-satisfies the backend check, and a code COMMENT mentioning
bb_serialize_format_register() (as bb_cache_serialize's render path
docstring does) no longer masks a real consumer as a backend.

Also fixes two LOW nits from review: reuse resolve_composition's
already-built component graph (new resolve_composition_with_graph) instead
of re-deriving each candidate consumer via derive_component, and drop the
needless sorted() over the (now call-site-detected) backend list.

7241 of 7856 branches covered (92.17%)

Branch coverage included in aggregate %.

12311 of 12485 relevant lines covered (98.61%)

1195.3 hits per line