ben-manes / caffeine / #5661

100%

master: 100%

push

github

Clear removeAll's pending in a finally like putAll

EventDispatcher.publish's executor-rejection legs are the accepted M3
racing-close divergence, and the sync-pending ThreadLocal leak needs the
executor to flip accepting to rejecting mid-loop to occur at all. The
bulk ops getAll and putAll already wrap their loop in a try..finally so
awaitSynchronous clears pending even when the loop throws, but
removeAll(Set) awaited outside any finally -- bring it into line with
putAll so a mid-loop throw still clears the queued synchronous futures.

Documents the leg analysis in the racing-close (M3) note.

4194 of 4201 branches covered (99.83%)

5 of 5 new or added lines in 1 file covered. (100.0%)

8455 of 8455 relevant lines covered (100.0%)

1.0 hits per line