TheKevJames / coveralls-python / 84603197-598b-44c1-9f00-d106817ac868

95%

master: 94%

Build Type

Pull #752

circleci

Committed by TheKevJames

Commit Message

fix(cli): don't let the default --rcfile clobber a config-file value

The CLI always forwarded rcfile='.coveragerc' as a highest-precedence override,
so an rcfile/config_file set in .coveralls.yml was silently ignored (while its
deprecation warning still fired, implying it took effect).

Default --rcfile to None and let resolve() drop it, matching how the other
string flags already work, so the config-file value survives. coverage.py
treats config_file='.coveragerc' and the auto-discovery default identically, so
the no-config behaviour is unchanged.

Pull Request Pull Request #752: refactor(config): typed Config model with consistent CLI/env/file/SSL handling

Coverage Stats

156 of 166 branches covered (93.98%)

Branch coverage included in aggregate %.

234 of 237 new or added lines in 3 files covered. (98.73%)

7 existing lines in 2 files now uncovered.

509 of 536 relevant lines covered (94.96%)

5.7 hits per line