TheKevJames / coveralls-python / 29690607332

95%

master: 94%

Build Type

Pull #752

github

Committed by TheKevJames

Commit Message

refactor(config): make service_name always a string

service_name is now a plain str defaulting to 'coveralls-python' rather than
str | None resolved to that value later, so submit_report()'s
service_name.startswith('github') check can never hit None. The default literal
lives on the Config field (DEFAULT_SERVICE_NAME); _detect_ci() returns None
when no CI is detected and lets that default apply.

Pull Request Pull Request #752: refactor(config): typed Config model with consistent CLI/env/file/SSL handling

Coverage Stats

156 of 166 branches covered (93.98%)

Branch coverage included in aggregate %.

234 of 237 new or added lines in 3 files covered. (98.73%)

7 existing lines in 2 files now uncovered.

509 of 536 relevant lines covered (94.96%)

4.75 hits per line