ng-select / ng-select / 29674528341

94%

push

github

feat: enhance accessibility and interaction for selected items in ng-select (#2834)

* fix: add notched outline appearance to ng-select component

- Implemented a new 'outline' appearance for the ng-select component, featuring a notched outline that adjusts based on the placeholder width.
- Updated the component's HTML and SCSS to support the new appearance, ensuring proper styling and behavior.
- Enhanced unit tests to verify the rendering of notched outline elements and their sizing based on the placeholder.
- Updated documentation to reflect changes in testing expectations and component behavior.

This feature improves the visual consistency and usability of the ng-select component in material design contexts.

* docs: update SKILL.md to enhance theme verification and testing procedures

- Added instructions to verify all three themes (`default`, `material`, `ant`) when changing styles via the theme switcher.
- Clarified that unit tests now run in Vitest browser mode using real headless Chromium, improving layout measurement accuracy.
- Included information about saving screenshots of failed specs for easier debugging.
- Updated pipeline commands for testing and formatting to reflect new practices.

These changes improve documentation clarity and testing reliability for the ng-select component.

* fix: prevent dropdown close when click target shifts after mousedown and in shadow DOM

Fixes #2773 (the only open issue); mention it supersedes #2777, #2726, and #2442 — those you'd close manually, ideally crediting the authors with Co-authored-by: Pankaj Parkar / Gudz Danil / Oliver Günther lines. #2441 is already closed and needs no action.

* fix: improve dropdown interaction handling for mousedown and click events

- Updated NgDropdownPanelComponent to ensure the dropdown remains open when the mousedown occurs inside the select and the click lands outside, addressing layout shifts that may occur (#2773).
- Enhanced the handling of outside click event... (continued)

898 of 978 branches covered (91.82%)

Branch coverage included in aggregate %.

25 of 27 new or added lines in 4 files covered. (92.59%)

1292 of 1355 relevant lines covered (95.35%)

269.63 hits per line