ben-manes / caffeine / #5655

100%

master: 100%

push

github

Keep a superseded refresh from discarding its successor

A refresh whose value or writeTime changed while in-flight takes the
completion reject branch, which set only preserveTimestamps. remap then
ran a by-key discardRefresh that removed a newer refresh's registration;
the successor completed un-owned and its freshly loaded value was
silently discarded, leaving the cache stale until the next
refresh-eligible read.

The refreshes map holds one future per key, so a by-key discard is safe
only for the owner. Set preserveRefresh = !owned on the reject branch of
all three completion paths (LocalLoadingCache.refresh,
LocalAsyncLoadingCache.tryComputeRefresh, BoundedLocalCache
.refreshIfNeeded), mirroring the already owner-scoped error path.

4165 of 4172 branches covered (99.83%)

6 of 6 new or added lines in 3 files covered. (100.0%)

8425 of 8425 relevant lines covered (100.0%)

1.0 hits per line