kaidokert / fixed-bigint-rs / 29658051300

98%

main: 97%

Build Type

Pull #146

github

Committed by kaidokert

Commit Message

Fix const_ct scan comments to state the real bounds/precondition mechanism

const_leading_zeros_ct's comment claimed `#[inline]` keeps `array.len()`
compile-time known so the access is bounds-check-free. That only holds
for the FixedUInt caller (whole array, const N); the heapless caller
passes a runtime-length `&self.limbs[..len]`. Elision actually comes from
the loop invariant `index < array.len()` (index only descends from len),
which holds regardless of whether the length is a constant — so the
runtime-length slice is fine too. Document that instead.

While here, make const_cmp_ct's comment spell out the equal-length
precondition the slice types no longer encode: the loop bounds on a.len()
and indexes b[index] in lockstep, so a shorter b would panic.

Pull Request Pull Request #146: Share FixedUInt/HeaplessBigInt code where the constraints allow

Coverage Stats

60 of 60 new or added lines in 6 files covered. (100.0%)

6 existing lines in 3 files now uncovered.

4171 of 4269 relevant lines covered (97.7%)

6657.44 hits per line