cameri / nostream / 29647581350

69%

push

github

fix: stop hitting additional rate limit windows once a client is already limited (#686)

isRateLimited() in EventMessageHandler and WebSocketAdapter iterated every
configured rate limit window and called rateLimiter.hit() even after an
earlier window had already tripped. Each hit() call executes a Lua script
against Redis, so a client already being rate-limited caused N redundant
Redis writes per message instead of one. Both methods now return as soon
as the first exceeded window is found.

Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
Co-authored-by: Ricardo Cabral <me@ricardocabral.io>

2105 of 3478 branches covered (60.52%)

Branch coverage included in aggregate %.

3 of 4 new or added lines in 2 files covered. (75.0%)

4766 of 6679 relevant lines covered (71.36%)

19.74 hits per line