ponder-lab / Hybridize-Functions-Refactoring / #2563

83%

push

github

Bump Ariadne to 0.52.36 and make the primitive exemption star-arg-aware (#800)

* Exempt defaulted-never-supplied primitive parameters from HAS_PRIMITIVE_PARAMETERS

The precondition declines a function with a primitive parameter because a
varying primitive argument induces retracing. A parameter that declares a
default and is supplied by no call site does not vary: it is always the
default, a single constant, so it induces no retracing and is not the risk the
precondition guards against. `inferPrimitiveParameters` now exempts such a
parameter, the supplied-parameter analysis of `inferSuppliedParameters` (#788)
applied on the primitive-parameter axis rather than the input-signature one.

The exemption is conservative on ignorance, mirroring #788: only
`isSuppliedAtCallSite() == FALSE` (definitely not supplied) exempts; `null`
(undetermined) does not. The IR parameter index maps to the positional
`Parameter` at `getIndex() == irParamIndex - 1`; keyword-only parameters share
the index space and are excluded via a new `Parameter.isKeywordOnly()`.

This changes behavior for module-level functions now, where a defaulted
parameter's default is already materialized in the pointer analysis, so a
never-supplied defaulted primitive currently over-declines a function that is
otherwise hybridizable. `testExemptDefaultedUnsuppliedPrimitive` covers that
directly (the function is optimizable only with the exemption), and
`testDefaultedSuppliedPrimitiveStillDeclines` guards that a supplied defaulted
primitive still declines.

For a trampolined instance method the default is not materialized until
Ariadne 0.52.35 (wala/ML#743), so the same over-decline appears there only on
that bump. `testDefaultedPrimitiveMethodTripwire` is the unit guard for it: it
passes on the current release through the empty-points-to path, flips red on
the 0.52.35 bump without this exemption, and the exemption restores it. That is
the `LayerNormalization.call` regression the corpus check surfa... (continued)

22 of 23 new or added lines in 2 files covered. (95.65%)

2342 of 2836 relevant lines covered (82.58%)

0.83 hits per line