sgerrand / ex_bamboo_hr / 29641326071

100%

Build Type

push

github

Committed by sgerrand

Commit Message

fix(employee,files): don't crash when http_client ignores expose_headers

Employee.add/2 and Files upload/6 matched only {:ok, %{headers: _}},
with no clause for a custom :http_client that doesn't honor
expose_headers — that shape mismatch raised CaseClauseError instead of
returning {:error, _}, violating the "never raise from public API"
rule. Added a fallback branch, and extracted the duplicated
location-header parsing into BambooHR.ResponseHeaders.

Coverage Stats

7 of 8 new or added lines in 3 files covered. (87.5%)

1 existing line in 1 file now uncovered.

122 of 124 relevant lines covered (98.39%)

38.44 hits per line